-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve stubs part two #24
Conversation
My favourite part of making gifs. :) It's the ultimate unit test.
Yep, just drag and drop it into any issue, even here. It'll generate a universally unique link that never expires and can be used anywhere. If your gif is larger than 10 mb it won't work, but your gif should not be more than 10 mb. Actually, make it an MP4 if you can, it'll be smaller and more crisp. Still try keep it under 10 seconds though, else split it up into multiple gifs that show off one small feature at a time. |
9a9146f
to
95d8f76
Compare
0a063b7
to
744a4e2
Compare
Uploading some videos for the readme Auto-completion cmdc_completion_cropped.mp4Type checking in action cmdc_type_checking_cropped.mp4 |
Ah, looks like the @mottosso do you prefer the videos to display like in my previous comment (collapsable and with playback controls) or more like gifs (no controls, with autoplay and looping)? |
Hah, plays fine on chrome but not firefox, |
All ready to go if that works for you 👍 |
Looks good to me! I made the gifs a bit smaller to make it fit in a little better with the surrounding text. |
So, when trying to record the gif for the readme, I realized the completion wasn't working on some classes like
SelectionList
.Turns out pybind11-stubgen gets a bit confused when a class has an inner class defined and tries to import the parent class as a module. This is tracked by this issue: sizmailov/pybind11-stubgen#36
I've opted to just remove the unwanted imports once the stubs are generated, might be a bit brute force but that felt like the only option that didn't cause other issues somewhere else in the stubs.
I'll also update the readme and contributing.md as part of this PR.
@mottosso is there a good place where I can store the gif?