QtPyConvert modifications #285

Ahuge · 2018-04-17T18:43:54Z

Hey @mottosso and team.

This is a patchset that we have applied for QtPyConvert and is something that we require for introspecting against Qt.py

Could we take some time in the near future to talk through these changes and merge them in if we are all ok with them?

… I can read it via QtPyConvert

…troducing a new mapping syntax with the value being a list. The first value is the namespace and the second is the actual pycallable that it gets mapped to. Will be useful for QtCompat mappings.

… for the new value list syntax.

…copied it over above correctly

… above correctly

houndci-bot · 2018-04-17T18:44:01Z

Qt.py

@@ -1726,3 +1819,4 @@ def _install():
 # CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
 # TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
 # SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+


blank line at end of file

Ahuge · 2018-04-17T18:49:19Z

Travis has some issues.

HOLD on this until I fix those.

Also updating the _setup code to attempt importing the top level extras too if the module level ones failed. Pulling getCppPointer out to the module scope for introspection.

…it into this branch yet. Woops. This appears to fix those issues in my local nosetester.

houndci-bot · 2018-04-17T20:58:52Z

Qt.py

+                dst_value = _part
+            except AttributeError:
+                # If the member we want to store in the namespace does not exist,
+                # there is no need to continue. This can happen if a request was


line too long (80 > 79 characters)

houndci-bot · 2018-04-17T20:58:52Z

Qt.py

+                    _part = getattr(_part, member)
+                dst_value = _part
+            except AttributeError:
+                # If the member we want to store in the namespace does not exist,


line too long (81 > 79 characters)

… It's not in trunk...

Ahuge · 2018-04-17T21:21:28Z

Canceling this for now. I want to make some more changes

Ahuge · 2018-04-17T21:59:43Z

Was having issues testing locally but think I got it now.

… standalone

…ment

mottosso

Great job! Especially like the updated misplaced_members, smart.

mottosso · 2018-04-17T23:12:54Z

Qt.py

+
+"""Default binding ordering.
+
+Brought into globals so I can introspect against it


This seems better suited for a commit message.

mottosso · 2018-04-17T23:20:17Z

Qt.py

+        return the newly created instance of the user interface.
+
+    """
+    # Not sure where this code came from.


If you select a line and hit "Blame" in the GitHub GUI, it'll take you to where that line was introduced, along with the commit message for it.

e4a736a

It was deleted recently, but I can't locate the PR for it. :S Nevertheless, you can remove it.

mottosso · 2018-04-17T23:21:50Z

Qt.py

@@ -881,7 +1180,13 @@ def _setup(module, extras):
            submodule = _import_sub_module(
                module, name)
        except ImportError:
-            continue
+            try:


What's happening here?

This allows support for keeping sip/shiboken around in Qt.
I am using this for the changes in the getCppPointer unified function above.
If you look at L1389 for example, we are adding "shiboken" and "sip" to the extras that get passed into this.
This part allows us to bind it to Qt._sip and Qt._shiboken.

Ah, I see. I wonder whether this is better suited to be hosted inside your project. I'd expect access to Qt._sip to break with running under PySide, and vice versa?

Under PySide Qt._sip doesn't exist. It just wouldn't be an attribute. The extras list is specific to each binding's setup function.

This was just support for stuff that used those binding specific modules to defer the actual function call to the unified _wrapinstance for example

Ok, I suppose so long as it has the _-prefix then it shouldn't cause any trouble.

The reason I'm weary is because the underscore == private concept isn't obvious to everyone; I sometimes get questions and feature requests for those, where they've already built their tool around it.

Then I have to explain that "oh, yes it is useful and you can technically use it, but you shouldn't". They won't care, until we remove it at which point they come back "Hey, it's broken, you suck!" :)

I forget, if it has a double-underscore, can you still access it externally, e.g. Qt.__sip?

I forget, if it has a double-underscore, can you still access it externally, e.g. Qt.__sip?

You should be able to access it, but the linters will complain. And so would hound, I presume?

printf "_x = True\n__x = True" > privtest.py python3.6 -c "import privtest; print(privtest._x); print(privtest.__x)" True True

Technically linters are going to get mad at QtPyConvert using any private underscore things from Qt.py

So I think this is an acceptable solution for QtPyConvert if you are ok with it.

I agree. Hound is great though, as it keeps Qt.py tidy. Unfortunately, it doesn't seem like you can tell hound to ignore certain linting errors: houndci/hound#1184

I can make it a double underscore if we'd like, however it might make more sense to think about
"an api" to develop on top of. @mottosso brought this up in the gitter chat briefly.

Would you be ok if we kept it private for now and once we decide about some sort of Qt.py api we can discuss moving it then?

All fine by me. I honestly haven't had time to go through this PR properly and will leave it up to you guys if you're okay with that.

mottosso · 2018-04-17T23:24:04Z

Qt.py

    preferred_order = list(
        b for b in QT_PREFERRED_BINDING.split(os.pathsep) if b
    )

-    order = preferred_order or default_order
+    order = preferred_order or _QT_PREFERRED_BINDING_DEFAULT_ORDER


I think if you want access to these we should probably handle the above parsing from environment variable to list at module-level too, so you get the same order the user has specified. Could possibly move the preferred_order parsing to the top of the module.

Otherwise, I expect what may happen is users complaining that they aren't able to control the resolution order, even though "it works on in Maya" etc.

I'm just using it as a list of bindings supported by Qt.py

I don't need the order or, as far as I can think, the subset that they want to support.
It's used to programmatically decide if a module is supported by Qt.py and if I am to rely on Qt.py for conversion or to see if there are custom mappings that the user provided.

The supported bindings is fixed and won't change. Can you redefine this list internally in QtPyConvert? It'd mean one less module-level constant to worry about in Qt.py.

Sounds good, I'll just ingest it into QtPyConvert

…ve been something I added at some point.

fredrikaverpil · 2018-04-18T06:30:34Z

Just for anyone else who might want to use this version of Qt.py against running code, it can be pip-installed easily:

pip install git+https://github.com/digitaldomain/Qt.py.git@QtPyConvert_modifications

…onger doing any name mangling

…nvert will maintain a copy of this list for itself.

houndci-bot · 2018-04-18T15:59:59Z

Qt.py

    try:
        try:
            # Before merge of PySide and shiboken
            import shiboken
        except ImportError:
            # After merge of PySide and shiboken, May 2017
            from PySide import shiboken
+        extras.append("shiboken")
+    except ImportError:
+        shiboken = None


local variable 'shiboken' is assigned to but never used

houndci-bot · 2018-04-18T15:59:59Z

Qt.py

    try:
        try:
            # Before merge of PySide and shiboken
            import shiboken2
        except ImportError:
            # After merge of PySide and shiboken, May 2017
            from PySide2 import shiboken2
+        extras.append("shiboken2")
+    except ImportError:
+        shiboken2 = None


local variable 'shiboken2' is assigned to but never used

Ahuge · 2018-04-23T18:02:09Z

Hey, just checking in, are you waiting on me for something still? I just want to make sure I am not holding you back.

mottosso · 2018-04-24T00:26:21Z

Sorry, it had slipped my mind. It looks allright to me, let's flip the switch!

Alex Hughes added 10 commits April 16, 2018 14:43

Moving loadUi higher up so I can access it

b8f01e5

Pulling out the QT_PREFERRED_BINDING_DEFAULT_ORDER to module scope so…

3acbddf

… I can read it via QtPyConvert

Moving _qInstallMessageHandler up higher so I can access it

5e2a07f

Removing duplicate _wrapInstance

0bac153

Adding some missplaced members mappings to use in conversion. Also in…

62f2967

…troducing a new mapping syntax with the value being a list. The first value is the namespace and the second is the actual pycallable that it gets mapped to. Will be useful for QtCompat mappings.

Adding custom patch for _reassign_misplaced_members function to allow…

f4829b5

… for the new value list syntax.

Commenting out the local application of the QtCompat code.

8aff731

Removing the comment qInstallMessageHandler as I've confirmed that I …

356c663

…copied it over above correctly

Removing the comment tranlate as I've confirmed that I copied it over…

cdec55f

… above correctly

Versioning up the beta

d82456b

houndci-bot reviewed Apr 17, 2018

View reviewed changes

Alex Hughes added 3 commits April 17, 2018 13:21

Updating a few of the introspection bindings so they are correct

d53632e

Also updating the _setup code to attempt importing the top level extras too if the module level ones failed. Pulling getCppPointer out to the module scope for introspection.

Removing the last line for hound

7964978

Previously was ignoring the internal value. I hadn't pushed that comm…

03a4555

…it into this branch yet. Woops. This appears to fix those issues in my local nosetester.

houndci-bot reviewed Apr 17, 2018

View reviewed changes

Alex Hughes added 2 commits April 17, 2018 14:00

Woof Hound fixes

b0e4e94

Commenting out the runtimeerror code that I added by mistake I think.…

6964ab0

… It's not in trunk...

Ahuge closed this Apr 17, 2018

Alex Hughes added 2 commits April 17, 2018 14:28

Patching the wrapInstance call like I didfor the other QtCompat methods

180ee01

Ths is<Binding> is with an uppercase I

95e1bcd

Ahuge reopened this Apr 17, 2018

Alex Hughes added 2 commits April 17, 2018 15:20

Adding some code to manage when shiboken is part of PySide instead of…

81a2dfa

… standalone

Removing the pyqtSignature because it doesn't have a newstyle replace…

6d608b7

…ment

mottosso requested changes Apr 17, 2018

View reviewed changes

Alex Hughes added 2 commits April 17, 2018 17:05

Removing the sring message that should have been a commit message.

ea6974d

Removing commented code. @mottosso confirmed it was unneeded. Must ha…

e3fd773

…ve been something I added at some point.

Alex Hughes added 2 commits April 18, 2018 08:52

Simplifying the _setup importing support for non parent members. No l…

ea31feb

…onger doing any name mangling

Removing the global default order and returning it back local. QtPyCo…

cff00e7

…nvert will maintain a copy of this list for itself.

houndci-bot reviewed Apr 18, 2018

View reviewed changes

Woof! Hound unused variables issue.

c70c8bc

mottosso merged commit 2c4a0e0 into mottosso:master Apr 24, 2018

Ahuge mentioned this pull request Apr 24, 2018

Binding specific replacement mappings as a dictionary, similar to _common_members #211

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

QtPyConvert modifications #285

QtPyConvert modifications #285

Ahuge commented Apr 17, 2018

houndci-bot Apr 17, 2018

Ahuge commented Apr 17, 2018

houndci-bot Apr 17, 2018

houndci-bot Apr 17, 2018

Ahuge commented Apr 17, 2018

Ahuge commented Apr 17, 2018

mottosso left a comment

mottosso Apr 17, 2018

Ahuge Apr 18, 2018

mottosso Apr 17, 2018

Ahuge Apr 18, 2018

mottosso Apr 17, 2018

Ahuge Apr 17, 2018

mottosso Apr 18, 2018

Ahuge Apr 18, 2018

mottosso Apr 18, 2018 •

edited

Loading

fredrikaverpil Apr 18, 2018 •

edited

Loading

Ahuge Apr 18, 2018

fredrikaverpil Apr 18, 2018

Ahuge Apr 18, 2018

fredrikaverpil Apr 18, 2018

mottosso Apr 17, 2018

Ahuge Apr 18, 2018

mottosso Apr 18, 2018

Ahuge Apr 18, 2018

fredrikaverpil commented Apr 18, 2018

houndci-bot Apr 18, 2018

houndci-bot Apr 18, 2018

Ahuge commented Apr 23, 2018

mottosso commented Apr 24, 2018


		"""Default binding ordering.

		Brought into globals so I can introspect against it

QtPyConvert modifications #285

QtPyConvert modifications #285

Conversation

Ahuge commented Apr 17, 2018

Choose a reason for hiding this comment

Ahuge commented Apr 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ahuge commented Apr 17, 2018

Ahuge commented Apr 17, 2018

mottosso left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mottosso Apr 18, 2018 • edited Loading

Choose a reason for hiding this comment

fredrikaverpil Apr 18, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fredrikaverpil commented Apr 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ahuge commented Apr 23, 2018

mottosso commented Apr 24, 2018

mottosso Apr 18, 2018 •

edited

Loading

fredrikaverpil Apr 18, 2018 •

edited

Loading