Create Welcome panel in rn_inspector #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motiz88
reviewed
Jul 25, 2023
motiz88
reviewed
Jul 25, 2023
huntie
commented
Jul 26, 2023
| @@ -177,6 +177,7 @@ grd_files_release_sources = [ | |||
| "front_end/Images/popup.svg", | |||
| "front_end/Images/preview_feature_video_thumbnail.svg", | |||
| "front_end/Images/profile.svg", | |||
| "front_end/Images/react_native/welcomeIcon.png", | |||
There was a problem hiding this comment.
Actually perhaps these could be scoped by panel (rn_welcome/) 🤔
motiz88
reviewed
Aug 23, 2023
motiz88
added a commit
that referenced
this pull request
Aug 23, 2023
* Create Welcome panel in rn_inspector * Update RN debugger brand name to "React Native JS Inspector" --------- Co-authored-by: Moti Zilberman <motiz88@gmail.com>
motiz88
pushed a commit
that referenced
this pull request
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a minimal "Welcome" panel behind the experiment flag
REACT_NATIVE_SPECIFIC_UI.Test plan
The appearance of this panel is intended to be a simple splash screen. It adheres to Chrome DevTools UI patterns (fonts and colours), and may move to a collapsible panel later.
Light appearance
Dark appearance
Accessibility (Lighthouse)