ES-90 review changes #346
Merged
ES-90 review changes #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ase-101
approved these changes
Sep 8, 2023
ase-101
added a commit
that referenced
this pull request
Sep 12, 2023
* [BUGFIX] updated kernel.keymanager depenency version to resolve build issues * added thumprint related logic * Changes made in Jws builder * modified consentHelperService * done some changes in consentHelperService * added modified testcase with signature verification * done signature related changes * [ES-90] done modification regarding signature verification now it is working * done change accorting to review comments * added new method for getting public key registry * now we are using idHash isnted of psuToken to find public Key registroy * verifid signature varification with postman now using Idhash istead of Psutoke * done some correction * add signatureFormate anotation for LinkedConsentRequestV2 : * review changes * review changes * added test case and done review changes * Modified the version * added migration script to add thumbprint * review changes * review changes * review changes * review changes * review changes * review changes * review changes * review changes * reveiw changes * merged the develop and corrected some test cases * review changes * cherry pick from 1.1.0 dp_upgrade_script * changes for deployment in dev1 * soran cloud coverage increased * review changes * review changes * review changes * review chages * review changes (#346) * review changes * review changes * review change for consent and updatescript (#365) * review changes * review changes * review changes * review changes in consentHelperService and upgradeScript * review changes * Review comments fix --------- Co-authored-by: Hitesh Jain <jainhitesh9998@gmail.com> Co-authored-by: kaifk468 <74772315+kaifk468@users.noreply.github.com> Co-authored-by: Mohd Kaif Siddique <kaifk468@gmail.com> Co-authored-by: Venkata Saidurga Polamraju <saidurgacsea@gmail.com> Co-authored-by: Vishwa <visu.vs1@gmail.com> Co-authored-by: ase-101 <>
ase-101
added a commit
that referenced
this pull request
Sep 19, 2023
* Updated README.md files * Changed pom version to 1.2.1-SNAPSHOT (#362) Co-authored-by: ase-101 <> * Update init_values.yaml (#364) Signed-off-by: Keshav Mishra <chandrakeshavmishra@gmail.com> * Updated README files * Updated README files * [ADDED] new ui design * ES-90 (#368) * [BUGFIX] updated kernel.keymanager depenency version to resolve build issues * added thumprint related logic * Changes made in Jws builder * modified consentHelperService * done some changes in consentHelperService * added modified testcase with signature verification * done signature related changes * [ES-90] done modification regarding signature verification now it is working * done change accorting to review comments * added new method for getting public key registry * now we are using idHash isnted of psuToken to find public Key registroy * verifid signature varification with postman now using Idhash istead of Psutoke * done some correction * add signatureFormate anotation for LinkedConsentRequestV2 : * review changes * review changes * added test case and done review changes * Modified the version * added migration script to add thumbprint * review changes * review changes * review changes * review changes * review changes * review changes * review changes * review changes * reveiw changes * merged the develop and corrected some test cases * review changes * cherry pick from 1.1.0 dp_upgrade_script * changes for deployment in dev1 * soran cloud coverage increased * review changes * review changes * review changes * review chages * review changes (#346) * review changes * review changes * review change for consent and updatescript (#365) * review changes * review changes * review changes * review changes in consentHelperService and upgradeScript * review changes * Review comments fix --------- Co-authored-by: Hitesh Jain <jainhitesh9998@gmail.com> Co-authored-by: kaifk468 <74772315+kaifk468@users.noreply.github.com> Co-authored-by: Mohd Kaif Siddique <kaifk468@gmail.com> Co-authored-by: Venkata Saidurga Polamraju <saidurgacsea@gmail.com> Co-authored-by: Vishwa <visu.vs1@gmail.com> Co-authored-by: ase-101 <> * Support for mobile view * ES-209 (#370) Co-authored-by: ase-101 <> * [MODIFIED] rename handleMoreWaysToSignIn to handleBackButtonClick, utilService to walletService * [REMOVE] remove inji from every translation * [FIXES] client logo image, loadinIndicator gap, otherissue * Support for mobile view * ES-185 (#371) Co-authored-by: ase-101 <> * [ADDED] wallet.config properties in local & dev * [MODIFIED] rtl changes for esignet images * Develop (#375) * ES-90 * ES-90 --------- Co-authored-by: ase-101 <> * Es-90 Reverted the constant changes (#376) Co-authored-by: ase-101 <> * Changed pom version to 1.2.0-SNAPSHOT * Changed pom version to 1.2.0-SNAPSHOT --------- Signed-off-by: Keshav Mishra <chandrakeshavmishra@gmail.com> Co-authored-by: KONIJETI YASWANTHA NAGARJUNA <50859121+YaswanthNagarjuna@users.noreply.github.com> Co-authored-by: Keshav Mishra <chandrakeshavmishra@gmail.com> Co-authored-by: anshulv1401 <31562315+anshulv1401@users.noreply.github.com> Co-authored-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> Co-authored-by: Hitesh Jain <jainhitesh9998@gmail.com> Co-authored-by: kaifk468 <74772315+kaifk468@users.noreply.github.com> Co-authored-by: Mohd Kaif Siddique <kaifk468@gmail.com> Co-authored-by: Venkata Saidurga Polamraju <saidurgacsea@gmail.com> Co-authored-by: Vishwa <visu.vs1@gmail.com> Co-authored-by: Sasikumar Ganesan <gsasikumar@gmail.com> Co-authored-by: ase-101 <>
ase-101
added a commit
to ase-101/idp
that referenced
this pull request
Jan 22, 2024
* Updated README.md files * Changed pom version to 1.2.1-SNAPSHOT (mosip#362) Co-authored-by: ase-101 <> * Update init_values.yaml (mosip#364) Signed-off-by: Keshav Mishra <chandrakeshavmishra@gmail.com> * Updated README files * Updated README files * [ADDED] new ui design * ES-90 (mosip#368) * [BUGFIX] updated kernel.keymanager depenency version to resolve build issues * added thumprint related logic * Changes made in Jws builder * modified consentHelperService * done some changes in consentHelperService * added modified testcase with signature verification * done signature related changes * [ES-90] done modification regarding signature verification now it is working * done change accorting to review comments * added new method for getting public key registry * now we are using idHash isnted of psuToken to find public Key registroy * verifid signature varification with postman now using Idhash istead of Psutoke * done some correction * add signatureFormate anotation for LinkedConsentRequestV2 : * review changes * review changes * added test case and done review changes * Modified the version * added migration script to add thumbprint * review changes * review changes * review changes * review changes * review changes * review changes * review changes * review changes * reveiw changes * merged the develop and corrected some test cases * review changes * cherry pick from 1.1.0 dp_upgrade_script * changes for deployment in dev1 * soran cloud coverage increased * review changes * review changes * review changes * review chages * review changes (mosip#346) * review changes * review changes * review change for consent and updatescript (mosip#365) * review changes * review changes * review changes * review changes in consentHelperService and upgradeScript * review changes * Review comments fix --------- Co-authored-by: Hitesh Jain <jainhitesh9998@gmail.com> Co-authored-by: kaifk468 <74772315+kaifk468@users.noreply.github.com> Co-authored-by: Mohd Kaif Siddique <kaifk468@gmail.com> Co-authored-by: Venkata Saidurga Polamraju <saidurgacsea@gmail.com> Co-authored-by: Vishwa <visu.vs1@gmail.com> Co-authored-by: ase-101 <> * Support for mobile view * ES-209 (mosip#370) Co-authored-by: ase-101 <> * [MODIFIED] rename handleMoreWaysToSignIn to handleBackButtonClick, utilService to walletService * [REMOVE] remove inji from every translation * [FIXES] client logo image, loadinIndicator gap, otherissue * Support for mobile view * ES-185 (mosip#371) Co-authored-by: ase-101 <> * [ADDED] wallet.config properties in local & dev * [MODIFIED] rtl changes for esignet images * Develop (mosip#375) * ES-90 * ES-90 --------- Co-authored-by: ase-101 <> * Es-90 Reverted the constant changes (mosip#376) Co-authored-by: ase-101 <> * Changed pom version to 1.2.0-SNAPSHOT * Changed pom version to 1.2.0-SNAPSHOT --------- Signed-off-by: Keshav Mishra <chandrakeshavmishra@gmail.com> Co-authored-by: KONIJETI YASWANTHA NAGARJUNA <50859121+YaswanthNagarjuna@users.noreply.github.com> Co-authored-by: Keshav Mishra <chandrakeshavmishra@gmail.com> Co-authored-by: anshulv1401 <31562315+anshulv1401@users.noreply.github.com> Co-authored-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> Co-authored-by: Hitesh Jain <jainhitesh9998@gmail.com> Co-authored-by: kaifk468 <74772315+kaifk468@users.noreply.github.com> Co-authored-by: Mohd Kaif Siddique <kaifk468@gmail.com> Co-authored-by: Venkata Saidurga Polamraju <saidurgacsea@gmail.com> Co-authored-by: Vishwa <visu.vs1@gmail.com> Co-authored-by: Sasikumar Ganesan <gsasikumar@gmail.com> Co-authored-by: ase-101 <>
ase-101
added a commit
to ase-101/idp
that referenced
this pull request
Jan 22, 2024
* [BUGFIX] updated kernel.keymanager depenency version to resolve build issues * added thumprint related logic * Changes made in Jws builder * modified consentHelperService * done some changes in consentHelperService * added modified testcase with signature verification * done signature related changes * [ES-90] done modification regarding signature verification now it is working * done change accorting to review comments * added new method for getting public key registry * now we are using idHash isnted of psuToken to find public Key registroy * verifid signature varification with postman now using Idhash istead of Psutoke * done some correction * add signatureFormate anotation for LinkedConsentRequestV2 : * review changes * review changes * added test case and done review changes * Modified the version * added migration script to add thumbprint * review changes * review changes * review changes * review changes * review changes * review changes * review changes * review changes * reveiw changes * merged the develop and corrected some test cases * review changes * cherry pick from 1.1.0 dp_upgrade_script * changes for deployment in dev1 * soran cloud coverage increased * review changes * review changes * review changes * review chages * review changes (mosip#346) * review changes * review changes * review change for consent and updatescript (mosip#365) * review changes * review changes * review changes * review changes in consentHelperService and upgradeScript * review changes * Review comments fix --------- Co-authored-by: Hitesh Jain <jainhitesh9998@gmail.com> Co-authored-by: kaifk468 <74772315+kaifk468@users.noreply.github.com> Co-authored-by: Mohd Kaif Siddique <kaifk468@gmail.com> Co-authored-by: Venkata Saidurga Polamraju <saidurgacsea@gmail.com> Co-authored-by: Vishwa <visu.vs1@gmail.com> Co-authored-by: ase-101 <> Signed-off-by: ase-101 <sunkadaeanusha@gmail.com>
ase-101
added a commit
to ase-101/idp
that referenced
this pull request
Jan 23, 2024
* Updated README.md files * Changed pom version to 1.2.1-SNAPSHOT (mosip#362) Co-authored-by: ase-101 <> * Update init_values.yaml (mosip#364) Signed-off-by: Keshav Mishra <chandrakeshavmishra@gmail.com> * Updated README files * Updated README files * [ADDED] new ui design * ES-90 (mosip#368) * [BUGFIX] updated kernel.keymanager depenency version to resolve build issues * added thumprint related logic * Changes made in Jws builder * modified consentHelperService * done some changes in consentHelperService * added modified testcase with signature verification * done signature related changes * [ES-90] done modification regarding signature verification now it is working * done change accorting to review comments * added new method for getting public key registry * now we are using idHash isnted of psuToken to find public Key registroy * verifid signature varification with postman now using Idhash istead of Psutoke * done some correction * add signatureFormate anotation for LinkedConsentRequestV2 : * review changes * review changes * added test case and done review changes * Modified the version * added migration script to add thumbprint * review changes * review changes * review changes * review changes * review changes * review changes * review changes * review changes * reveiw changes * merged the develop and corrected some test cases * review changes * cherry pick from 1.1.0 dp_upgrade_script * changes for deployment in dev1 * soran cloud coverage increased * review changes * review changes * review changes * review chages * review changes (mosip#346) * review changes * review changes * review change for consent and updatescript (mosip#365) * review changes * review changes * review changes * review changes in consentHelperService and upgradeScript * review changes * Review comments fix --------- Co-authored-by: Hitesh Jain <jainhitesh9998@gmail.com> Co-authored-by: kaifk468 <74772315+kaifk468@users.noreply.github.com> Co-authored-by: Mohd Kaif Siddique <kaifk468@gmail.com> Co-authored-by: Venkata Saidurga Polamraju <saidurgacsea@gmail.com> Co-authored-by: Vishwa <visu.vs1@gmail.com> Co-authored-by: ase-101 <> * Support for mobile view * ES-209 (mosip#370) Co-authored-by: ase-101 <> * [MODIFIED] rename handleMoreWaysToSignIn to handleBackButtonClick, utilService to walletService * [REMOVE] remove inji from every translation * [FIXES] client logo image, loadinIndicator gap, otherissue * Support for mobile view * ES-185 (mosip#371) Co-authored-by: ase-101 <> * [ADDED] wallet.config properties in local & dev * [MODIFIED] rtl changes for esignet images * Develop (mosip#375) * ES-90 * ES-90 --------- Co-authored-by: ase-101 <> * Es-90 Reverted the constant changes (mosip#376) Co-authored-by: ase-101 <> * Changed pom version to 1.2.0-SNAPSHOT * Changed pom version to 1.2.0-SNAPSHOT --------- Signed-off-by: Keshav Mishra <chandrakeshavmishra@gmail.com> Co-authored-by: KONIJETI YASWANTHA NAGARJUNA <50859121+YaswanthNagarjuna@users.noreply.github.com> Co-authored-by: Keshav Mishra <chandrakeshavmishra@gmail.com> Co-authored-by: anshulv1401 <31562315+anshulv1401@users.noreply.github.com> Co-authored-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> Co-authored-by: Hitesh Jain <jainhitesh9998@gmail.com> Co-authored-by: kaifk468 <74772315+kaifk468@users.noreply.github.com> Co-authored-by: Mohd Kaif Siddique <kaifk468@gmail.com> Co-authored-by: Venkata Saidurga Polamraju <saidurgacsea@gmail.com> Co-authored-by: Vishwa <visu.vs1@gmail.com> Co-authored-by: Sasikumar Ganesan <gsasikumar@gmail.com> Co-authored-by: ase-101 <> Signed-off-by: ase-101 <sunkadaeanusha@gmail.com>
ase-101
added a commit
to ase-101/idp
that referenced
this pull request
Jan 23, 2024
* [BUGFIX] updated kernel.keymanager depenency version to resolve build issues * added thumprint related logic * Changes made in Jws builder * modified consentHelperService * done some changes in consentHelperService * added modified testcase with signature verification * done signature related changes * [ES-90] done modification regarding signature verification now it is working * done change accorting to review comments * added new method for getting public key registry * now we are using idHash isnted of psuToken to find public Key registroy * verifid signature varification with postman now using Idhash istead of Psutoke * done some correction * add signatureFormate anotation for LinkedConsentRequestV2 : * review changes * review changes * added test case and done review changes * Modified the version * added migration script to add thumbprint * review changes * review changes * review changes * review changes * review changes * review changes * review changes * review changes * reveiw changes * merged the develop and corrected some test cases * review changes * cherry pick from 1.1.0 dp_upgrade_script * changes for deployment in dev1 * soran cloud coverage increased * review changes * review changes * review changes * review chages * review changes (mosip#346) * review changes * review changes * review change for consent and updatescript (mosip#365) * review changes * review changes * review changes * review changes in consentHelperService and upgradeScript * review changes * Review comments fix --------- Co-authored-by: Hitesh Jain <jainhitesh9998@gmail.com> Co-authored-by: kaifk468 <74772315+kaifk468@users.noreply.github.com> Co-authored-by: Mohd Kaif Siddique <kaifk468@gmail.com> Co-authored-by: Venkata Saidurga Polamraju <saidurgacsea@gmail.com> Co-authored-by: Vishwa <visu.vs1@gmail.com> Co-authored-by: ase-101 <>
zesu22
added a commit
to Infosys/esignet
that referenced
this pull request
Feb 9, 2024
* Updated README.md files * Changed pom version to 1.2.1-SNAPSHOT (mosip#362) Co-authored-by: ase-101 <> * Update init_values.yaml (mosip#364) Signed-off-by: Keshav Mishra <chandrakeshavmishra@gmail.com> * Updated README files * Updated README files * [ADDED] new ui design * ES-90 (mosip#368) * [BUGFIX] updated kernel.keymanager depenency version to resolve build issues * added thumprint related logic * Changes made in Jws builder * modified consentHelperService * done some changes in consentHelperService * added modified testcase with signature verification * done signature related changes * [ES-90] done modification regarding signature verification now it is working * done change accorting to review comments * added new method for getting public key registry * now we are using idHash isnted of psuToken to find public Key registroy * verifid signature varification with postman now using Idhash istead of Psutoke * done some correction * add signatureFormate anotation for LinkedConsentRequestV2 : * review changes * review changes * added test case and done review changes * Modified the version * added migration script to add thumbprint * review changes * review changes * review changes * review changes * review changes * review changes * review changes * review changes * reveiw changes * merged the develop and corrected some test cases * review changes * cherry pick from 1.1.0 dp_upgrade_script * changes for deployment in dev1 * soran cloud coverage increased * review changes * review changes * review changes * review chages * review changes (mosip#346) * review changes * review changes * review change for consent and updatescript (mosip#365) * review changes * review changes * review changes * review changes in consentHelperService and upgradeScript * review changes * Review comments fix --------- Co-authored-by: Hitesh Jain <jainhitesh9998@gmail.com> Co-authored-by: kaifk468 <74772315+kaifk468@users.noreply.github.com> Co-authored-by: Mohd Kaif Siddique <kaifk468@gmail.com> Co-authored-by: Venkata Saidurga Polamraju <saidurgacsea@gmail.com> Co-authored-by: Vishwa <visu.vs1@gmail.com> Co-authored-by: ase-101 <> * Support for mobile view * ES-209 (mosip#370) Co-authored-by: ase-101 <> * [MODIFIED] rename handleMoreWaysToSignIn to handleBackButtonClick, utilService to walletService * [REMOVE] remove inji from every translation * [FIXES] client logo image, loadinIndicator gap, otherissue * Support for mobile view * ES-185 (mosip#371) Co-authored-by: ase-101 <> * [ADDED] wallet.config properties in local & dev * [MODIFIED] rtl changes for esignet images * Develop (mosip#375) * ES-90 * ES-90 --------- Co-authored-by: ase-101 <> * Es-90 Reverted the constant changes (mosip#376) Co-authored-by: ase-101 <> * Changed pom version to 1.2.0-SNAPSHOT * Changed pom version to 1.2.0-SNAPSHOT --------- Signed-off-by: Keshav Mishra <chandrakeshavmishra@gmail.com> Co-authored-by: KONIJETI YASWANTHA NAGARJUNA <50859121+YaswanthNagarjuna@users.noreply.github.com> Co-authored-by: Keshav Mishra <chandrakeshavmishra@gmail.com> Co-authored-by: anshulv1401 <31562315+anshulv1401@users.noreply.github.com> Co-authored-by: Zeeshan Mehboob <zeeshan.mehboob@infosys.com> Co-authored-by: Hitesh Jain <jainhitesh9998@gmail.com> Co-authored-by: kaifk468 <74772315+kaifk468@users.noreply.github.com> Co-authored-by: Mohd Kaif Siddique <kaifk468@gmail.com> Co-authored-by: Venkata Saidurga Polamraju <saidurgacsea@gmail.com> Co-authored-by: Vishwa <visu.vs1@gmail.com> Co-authored-by: Sasikumar Ganesan <gsasikumar@gmail.com> Co-authored-by: ase-101 <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.