Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expand user path for Writer's output directory. #694

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

huxuan
Copy link
Contributor

@huxuan huxuan commented Jun 7, 2024

Description of changes:

When setting the out argument of Writer (e.g. MDSWriter) to something like ~/awesome-streamdataset, it will create a directory in current workdir named with "~" which is quite strange.

Issue #, if available:

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the contributor guidelines
  • This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I ran the tests locally to make sure it pass. (check out testing)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

BTW, it seems that pre-commit run -a and pytest -vv -s . does not work well on the latest main branch.

@huxuan huxuan marked this pull request as ready for review June 8, 2024 07:19
Copy link
Collaborator

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one small edit I made, other than that lgtm and will run CI on this. Thanks for the contribution @huxuan !!

streaming/base/format/base/writer.py Outdated Show resolved Hide resolved
@snarayan21
Copy link
Collaborator

snarayan21 commented Jun 11, 2024

BTW, it seems that pre-commit run -a and pytest -vv -s . does not work well on the latest main branch.

@huxuan Mind elaborating on what went wrong here?

Copy link
Collaborator

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@snarayan21 snarayan21 merged commit 8904102 into mosaicml:main Jun 11, 2024
8 checks passed
@huxuan huxuan deleted the huxuan/expanduser-out branch July 16, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants