Ensure shards cannot be larger than 4GB #672
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Based on issue #659, users have seen that shards exceeding 4GB are not possible since we are encoding sample byte offsets using uint32, which has a max value of
2**32 - 1
. To prevent users from hitting sample access errors much later, we instead will throw an error here.If there are future use cases that MUST use shards larger than 4GB, we can revisit this and increase the byte offset encoding type to uint64 if applicable. This is currently not the case for any workload we support, including vision.
Added unit tests to all 3 writer types ensuring that the error is thrown correctly.
Issue #, if available:
Merge Checklist:
Put an
x
without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
pre-commit
on my change. (check out thepre-commit
section of prerequisites)