Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded replication testing + documentation #607

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

snarayan21
Copy link
Collaborator

@snarayan21 snarayan21 commented Feb 23, 2024

Description of changes:

Expanded testing for the replication arg by including more possible values for the number of samples, canonical nodes, and batch size.

Adding documentation for this new feature as well.

Issue #, if available:

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the contributor guidelines
  • This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I ran the tests locally to make sure it pass. (check out testing)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

Copy link
Collaborator

@karan6181 karan6181 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@snarayan21
Copy link
Collaborator Author

going to add docs to this PR.

@snarayan21 snarayan21 changed the title Expanded replication testing Expanded replication testing + docs Feb 23, 2024
@snarayan21 snarayan21 changed the title Expanded replication testing + docs Expanded replication testing + documentation Feb 23, 2024
@snarayan21 snarayan21 merged commit ecfe3d0 into main Feb 23, 2024
6 checks passed
@snarayan21 snarayan21 deleted the saaketh/replication_testing_expansion branch February 23, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants