Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed condition for warning when partitioning over tiny datasets. #544

Merged
merged 5 commits into from
Dec 19, 2023

Conversation

snarayan21
Copy link
Collaborator

@snarayan21 snarayan21 commented Dec 19, 2023

Description of changes:

Previously, the condition used to calculate if there was enough padding to repeat samples in the partition was being calculated incorrectly. As a result, this was causing users to see warnings about dropped and repeated samples when they should not have been, which caused users to worry. This also caused samples to be padded in a different way. This has now been addressed by making sure that the condition is calculated in the correct way.

Added a test to ensure that this warning isn't thrown when we don't have issues with padding, i.e. num_samples is larger than num_gpus*num_physical nodes by a good amount.

Issue #, if available:

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the contributor guidelines
  • This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I ran the tests locally to make sure it pass. (check out testing)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

@karan6181 karan6181 merged commit cb8e872 into mosaicml:main Dec 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants