Fixed condition for warning when partitioning over tiny datasets. #544
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Previously, the condition used to calculate if there was enough padding to repeat samples in the partition was being calculated incorrectly. As a result, this was causing users to see warnings about dropped and repeated samples when they should not have been, which caused users to worry. This also caused samples to be padded in a different way. This has now been addressed by making sure that the condition is calculated in the correct way.
Added a test to ensure that this warning isn't thrown when we don't have issues with padding, i.e. num_samples is larger than num_gpus*num_physical nodes by a good amount.
Issue #, if available:
Merge Checklist:
Put an
x
without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
pre-commit
on my change. (check out thepre-commit
section of prerequisites)