Add flag to allow or reject datasets containing unsafe types (i.e., Pickle) #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karan6181
reviewed
Dec 4, 2023
snarayan21
reviewed
Dec 4, 2023
| @@ -125,7 +128,8 @@ def __init__(self, | |||
| shuffle_block_size: Optional[int] = None, | |||
| sampling_method: str = 'balanced', | |||
| sampling_granularity: int = 1, | |||
| batching_method: str = 'random') -> None: | |||
| batching_method: str = 'random', | |||
| allow_unsafe_types: bool = False) -> None: | |||
There was a problem hiding this comment.
Once this goes in, can you also submit a PR to foundry that upstreams this arg to there? I don't think diffusion repo needs it because it just passes in **kwargs, but foundry datasets don't do that.
karan6181
approved these changes
Dec 7, 2023
knighton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pickle serialization format, which is one of the available MDS encodings, is a potential security vulnerability. Here, we add a flag to either allow or reject datasets containing Pickle.
Work
allow_unsafe_types: bool = FalsetoStreamingDatasetallow_unsafe_types: booltoStream.get_shards()get_shards()validate(allow_unsafe_types)toReaderis_mds_encoding_safeto MDS'encodings.py_unsafe_mds_encodingsset to MDS'encodings.pyQuestions
safe/allow_unsafe_typesorsecure/allow_insecure_types(for comparable terminology, we currently havesafe_keep_zipand references to thread-safety in the codebase)? Currently going withsafe.Issue
STR-137