Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an exception if cache limit is too low #420

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

karan6181
Copy link
Collaborator

Description of changes:

  • If cache_limit is lower than a shard file size or lower than a few shard files sizes, raise an exception to raise a cache_limit. This is more of a better user experience. Hard to see a practical use-case where the cache_limit is this much low.

Issue #, if available:

#417

Merge Checklist:

Put an x without space in the boxes that apply. If you are unsure about any checklist, please don't hesitate to ask. We are here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the contributor guidelines
  • This is a documentation change or typo fix. If so, skip the rest of this checklist.
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the MosaicML team.
  • I have updated any necessary documentation, including README and API docs (if appropriate).

Tests

  • I ran pre-commit on my change. (check out the pre-commit section of prerequisites)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate).
  • I ran the tests locally to make sure it pass. (check out testing)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes.

@karan6181 karan6181 marked this pull request as ready for review September 8, 2023 02:54
Copy link
Collaborator

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the logic for getting the max shard size, lgtm!

streaming/base/dataset.py Outdated Show resolved Hide resolved
streaming/base/dataset.py Show resolved Hide resolved
Copy link
Collaborator

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@karan6181 karan6181 merged commit 890e499 into mosaicml:main Sep 8, 2023
6 checks passed
@karan6181 karan6181 deleted the fix_low_cache_limit branch September 8, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants