Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry based config - Part 1 #975

Merged
merged 67 commits into from
Mar 20, 2024
Merged

Registry based config - Part 1 #975

merged 67 commits into from
Mar 20, 2024

Conversation

dakinggg
Copy link
Collaborator

@dakinggg dakinggg commented Feb 14, 2024

Adds the core of the registry system

Along for the ride, adds some __all__s. Will do a follow up PR that goes through and makes sure all the __all__s are correct.

  • Manual test all register styles (registry-4-ia776l, temporarily commented out some loggers and registered them through the different registry methods)
  • Write stub of the docs section
  • Pass through code again

@dakinggg dakinggg changed the title [WIP] Registry based config Registry based config - Part 1 Mar 1, 2024
Copy link
Collaborator

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while we're at it, we should add trailing comma lint @b-chu ?

Mostly looks good to me. not doing detailed pass yet, but I like the design and no major comments. some minor questions mostly for me

README.md Outdated Show resolved Hide resolved
llmfoundry/registry.py Outdated Show resolved Hide resolved
scripts/train/train.py Outdated Show resolved Hide resolved
REGISTRY.md Outdated Show resolved Hide resolved
@mvpatel2000
Copy link
Collaborator

What's the appropriate level for testing here?

@dakinggg
Copy link
Collaborator Author

@mvpatel2000 I did manual test of all the registration methods (see description), and have unit tests for all the registering methods. What other testing are you thinking? I could run the regression tests against this PR, not sure how much that adds though.

Copy link
Collaborator

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but would like more eyes on this given big PR.

Do we need to update YAMLs?

llmfoundry/interfaces/callback_with_config.py Outdated Show resolved Hide resolved
@dakinggg
Copy link
Collaborator Author

@mvpatel2000 should not require any yaml updates as the yaml API is not changing.

tests/utils/test_builders.py Show resolved Hide resolved
llmfoundry/utils/builders.py Show resolved Hide resolved
llmfoundry/utils/builders.py Outdated Show resolved Hide resolved
llmfoundry/utils/builders.py Show resolved Hide resolved
scripts/train/train.py Show resolved Hide resolved
llmfoundry/utils/registry_utils.py Show resolved Hide resolved
llmfoundry/utils/registry_utils.py Outdated Show resolved Hide resolved
llmfoundry/utils/warnings.py Show resolved Hide resolved
llmfoundry/utils/registry_utils.py Outdated Show resolved Hide resolved
REGISTRY.md Show resolved Hide resolved
@dakinggg dakinggg merged commit 9bf3701 into mosaicml:main Mar 20, 2024
10 checks passed
@dakinggg dakinggg deleted the registry branch June 22, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants