-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up the logs, bump datasets and transformers #804
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! had a suggestion to use a context manager for filtering cases that require clean up
The noisiest logs were coming from an old datasets version. Bumping the datasets version ended up requiring bumping the transformers version due to a dependency quadrangle. So this PR is including the version bumps too (and associated workarounds).
llama2 finetuning, before and after, with and without flash attention enabled
![Screenshot 2023-12-15 at 1 37 06 PM](https://private-user-images.githubusercontent.com/43149077/290941589-bcd6ec46-1736-43e6-9b3b-36afa84969c2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjMwNzE3NjcsIm5iZiI6MTcyMzA3MTQ2NywicGF0aCI6Ii80MzE0OTA3Ny8yOTA5NDE1ODktYmNkNmVjNDYtMTczNi00M2U2LTliM2ItMzZhZmE4NDk2OWMyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODA3VDIyNTc0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThjYzliNjRlZmE2MzMwZjcwN2M0ZDc2YWY3NjkyYmViZjgxZjA1MGY1ZmJhNThkODliYTY5ZTg0ODQ1OTUxZTYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.btWjXbotYQ55NwW2zAF_vR9AZ5-xrQ0jwLfmbylARpA)
![Screenshot 2023-12-15 at 1 36 19 PM](https://private-user-images.githubusercontent.com/43149077/290941583-28ab471b-13e8-46de-ab36-062f0b52b88e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjMwNzE3NjcsIm5iZiI6MTcyMzA3MTQ2NywicGF0aCI6Ii80MzE0OTA3Ny8yOTA5NDE1ODMtMjhhYjQ3MWItMTNlOC00NmRlLWFiMzYtMDYyZjBiNTJiODhlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODA3VDIyNTc0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE4MDNlZGM2NGY3MjgyNzFlNDE4Zjk1MTFmYTc5MTU2ZjUyNDllODVkY2ZhMDc0ZjMwMGMzMGU1MWQzYjFjZjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ajxJVu12W58FxJ2SXKhfHPZ1-Ca14gV69I1_Aqw7TfE)
![Screenshot 2023-12-15 at 1 36 43 PM](https://private-user-images.githubusercontent.com/43149077/290941587-8f5ff80c-48b7-439f-ac4a-7b268567bdca.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjMwNzE3NjcsIm5iZiI6MTcyMzA3MTQ2NywicGF0aCI6Ii80MzE0OTA3Ny8yOTA5NDE1ODctOGY1ZmY4MGMtNDhiNy00MzlmLWFjNGEtN2IyNjg1NjdiZGNhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODA3VDIyNTc0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTM3NzVhYWFmYjZhZTNlYjA2ODkwNzI2ZjNjYjc2YjQ0ZGIyYmIwNDRhNjk4MTljYjczZmRjNjQ2MmQ3MGMzYjkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.YKY_xXUZX7xehGBJ_RWj2UQM-YO46QYX4t2otjHfHyM)
clean-logs-baseline-EJoND1
, after:clean-logs-local-after-slljhI
)Related transformers issues: