Add safe_load option to restrict HF dataset downloads to allowed file types #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irenedea
commented
Dec 12, 2023
irenedea
commented
Dec 12, 2023
irenedea
commented
Dec 13, 2023
irenedea
commented
Dec 13, 2023
dakinggg
reviewed
Dec 14, 2023
There was a problem hiding this comment.
generally lgtm. Could you provide some manual testing? Please test both using a custom file, and using both supported and unsupported datasets from the hub.
In the custom file and support hub dataset cases, check that it runs and also that startup time is not dramatically slower than previously.
For the unsupported hub dataset case, just make sure it errors in a reasonable way (i.e. doesn't hang or something)
dakinggg
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual Tests
test-safe-load-false-valid-hvr7NF - safe_load=False + valid dataset (runs successfully)
test-safe-load-LZNNUv - safe_load=True + valid dataset (runs successfully)
test-safe-load-squad-Lku1Q4 - safe_load=True + invalid dataset (fails with proper error)
test-no-safe-load-squad-jhdtOQ - safe_load=False + invalid dataset (loads the dataset, fails bc data formatting reasons)
safe_load does not add any noticeable overhead. Both runs (valid dataset with safe_load=True and with safe_load=False) take 7 min.