Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable GLU FFN type #796

Merged
merged 6 commits into from
Dec 13, 2023
Merged

Enable GLU FFN type #796

merged 6 commits into from
Dec 13, 2023

Conversation

vchiley
Copy link
Contributor

@vchiley vchiley commented Dec 9, 2023

  1. Enable GLU FFN
  2. enable user to set ffn_hidden_size directly.

dakinggg
dakinggg approved these changes Dec 11, 2023
View reviewed changes
llmfoundry/models/layers/ffn.py Outdated Show resolved Hide resolved
llmfoundry/models/layers/ffn.py Outdated Show resolved Hide resolved
llmfoundry/models/layers/ffn.py Outdated Show resolved Hide resolved
llmfoundry/models/layers/ffn.py Outdated Show resolved Hide resolved
vchiley and others added 2 commits December 11, 2023 15:46
@vchiley @dakinggg
Update llmfoundry/models/layers/ffn.py
39f4bfb 
Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
@vchiley
pr comments
0985662
@vchiley vchiley enabled auto-merge (squash) December 12, 2023 00:38
@vchiley vchiley merged commit 0797aa6 into mosaicml:main Dec 13, 2023
8 checks passed
@vchiley vchiley mentioned this pull request Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

@sashaDoubov sashaDoubov Awaiting requested review from sashaDoubov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vchiley @dakinggg