Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto packing fixes #783

Merged
merged 8 commits into from
Dec 11, 2023
Merged

Auto packing fixes #783

merged 8 commits into from
Dec 11, 2023

Conversation

irenedea
Copy link
Contributor

@irenedea irenedea commented Dec 7, 2023 •
edited
Loading

Fixes:

  1. use a temporary local directory when profiling with streaming, handles Reused local directory error
  2. handle tiny datasets that are smaller than device batch size
  3. handle small max_seq_len that caused max packing ratio to be less than min packing ratio

@irenedea irenedea changed the title Clean streaming memory after packing profiling Clean streaming memory after profiling packing Dec 7, 2023
@irenedea irenedea changed the title Clean streaming memory after profiling packing Auto packing fixes Dec 8, 2023
@irenedea irenedea marked this pull request as ready for review December 8, 2023 21:02
dakinggg
dakinggg approved these changes Dec 8, 2023
View reviewed changes
tests/data/test_packing.py Show resolved Hide resolved
@irenedea irenedea merged commit 34ec2f7 into mosaicml:main Dec 11, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@irenedea @dakinggg