Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker release on workflow_dispatch #763

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Docker release on workflow_dispatch #763

merged 1 commit into from
Nov 28, 2023

Conversation

bandish-shah
Copy link
Contributor

This PR updates the Docker release workflow so that we can release new images on a manual trigger.

  • pull_request events will push images to the Docker staging repo
  • push and workflow_dispatch events will push images to the production Docker repo

j316chuck
j316chuck approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@j316chuck j316chuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dakinggg feel free to submit a patch PR if you are not comfortable with people manually pushing to mosaicml/llm-foundry through workflow_dispatches.

@j316chuck j316chuck merged commit 34d04ea into main Nov 28, 2023
16 checks passed
@dakinggg dakinggg deleted the bandish/release_docker_manual_trigger branch February 3, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j316chuck j316chuck j316chuck approved these changes

@dakinggg dakinggg Awaiting requested review from dakinggg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bandish-shah @j316chuck