Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eval loader to eval script #742

Merged
merged 14 commits into from
Nov 30, 2023
Merged

Add eval loader to eval script #742

merged 14 commits into from
Nov 30, 2023

Conversation

aspfohl
Copy link
Contributor

@aspfohl aspfohl commented Nov 16, 2023

No description provided.

@aspfohl aspfohl marked this pull request as ready for review November 16, 2023 17:52
dakinggg
dakinggg reviewed Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please do a test run that does both normal eval and ICL eval to make sure it works?

llmfoundry/data/dataloader.py Show resolved Hide resolved
scripts/eval/eval.py Outdated Show resolved Hide resolved
llmfoundry/utils/builders.py Outdated Show resolved Hide resolved
irenedea
irenedea reviewed Nov 28, 2023
View reviewed changes
scripts/eval/eval.py Show resolved Hide resolved
scripts/eval/eval.py Show resolved Hide resolved
llmfoundry/utils/builders.py Outdated Show resolved Hide resolved
scripts/eval/eval.py Outdated Show resolved Hide resolved
scripts/eval/eval.py Show resolved Hide resolved
scripts/train/train.py Outdated Show resolved Hide resolved
tests/test_eval.py Outdated Show resolved Hide resolved
tests/test_eval.py Outdated Show resolved Hide resolved
llmfoundry/data/dataloader.py Show resolved Hide resolved
tests/test_dataloader.py Outdated Show resolved Hide resolved
dakinggg
dakinggg reviewed Nov 28, 2023
View reviewed changes
scripts/train/train.py Outdated Show resolved Hide resolved
dakinggg
dakinggg reviewed Nov 28, 2023
View reviewed changes
tests/data_utils.py Outdated Show resolved Hide resolved
dakinggg
dakinggg reviewed Nov 29, 2023
View reviewed changes
tests/data_utils.py Outdated Show resolved Hide resolved
dakinggg
dakinggg reviewed Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please include a manual test of:
(1) a training run with an eval loader
(2) an eval run with an eval loader

scripts/eval/eval.py Outdated Show resolved Hide resolved
@aspfohl
Copy link
Contributor Author

aspfohl commented Nov 30, 2023 •
edited
Loading

@dakinggg

a training run with an eval loader

mpt-1b-ctx-8k-gpus-8-3IPwqf

yaml diff from foundry
Screenshot 2023-11-30 at 12 45 53 PM

an eval run with an eval loader

mpt-eval-YwAj8C (stopped early)

yaml diff from foundry
Screenshot 2023-11-30 at 12 45 28 PM

dakinggg
dakinggg approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aspfohl aspfohl merged commit 3100859 into main Nov 30, 2023
10 checks passed
@aspfohl aspfohl deleted the anna/evalloader branch November 30, 2023 22:02
@aspfohl aspfohl mentioned this pull request Dec 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

@bmosaicml bmosaicml Awaiting requested review from bmosaicml

@irenedea irenedea Awaiting requested review from irenedea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aspfohl @irenedea @dakinggg