Enable tie_word_embeddings config setting to enable / disable weight tied embeddings
#728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchiley
force-pushed
the
notie_embd
branch
2 times, most recently
from
1fe7e55
to
83993bf
Compare
vchiley
changed the title
tie_word_embeddings config to enable / disable weight tied embeddings
vchiley
changed the title
tie_word_embeddings config to enable / disable weight tied embeddingstie_word_embeddings config setting to enable / disable weight tied embeddings
sashaDoubov
reviewed
Nov 10, 2023
Co-authored-by: Sasha Doubov <sasha.doubov@databricks.com>
dakinggg
reviewed
Nov 11, 2023
dakinggg
previously approved these changes
Nov 13, 2023
dakinggg
reviewed
Nov 13, 2023
dakinggg
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable disabling embedding weight tying
(Using huggingface
PretrainedConfig'stie_word_embeddingskwarg)Same seed, same config (except
tie_word_embeddings: {true, false}), produces slightly different convergence curvesand the resulting param count is different: