Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add load_strict_model_weights as an optional config parameter #655

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

AllenHW
Copy link
Contributor

@AllenHW AllenHW commented Oct 8, 2023

The parameter is already exposed in composer.Trainer. This change will expose it via train.py in llm-foundry

Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Allen!

@dakinggg
Copy link
Collaborator

dakinggg commented Oct 9, 2023

You'll need to run pre-commit to get the linting to pass. Let me know if you run into any issues there!

@AllenHW AllenHW marked this pull request as ready for review October 12, 2023 01:30
@dakinggg dakinggg enabled auto-merge (squash) October 12, 2023 22:42
@dakinggg
Copy link
Collaborator

Hey @AllenHW looks like I can't update your branch to main for you. If you could do that, it should auto merge after CI passes!

@dakinggg dakinggg merged commit 2c5965e into mosaicml:main Oct 18, 2023
12 checks passed
@AllenHW
Copy link
Contributor Author

AllenHW commented Oct 18, 2023

@dakinggg Sorry, I forgot to loop back to this last week. Thanks for helping merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants