Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag to disable train metrics #642

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Add flag to disable train metrics #642

merged 3 commits into from
Oct 3, 2023

Conversation

mvpatel2000
Copy link
Collaborator

Add flag to disable train metrics

@mvpatel2000 mvpatel2000 mentioned this pull request Oct 3, 2023
Merged
vchiley
vchiley approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@vchiley vchiley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if my suggestion helps make it more consistent or is just more confusing...

feel free to ignore. otherwise lgtm

llmfoundry/models/hf/hf_causal_lm.py Show resolved Hide resolved
llmfoundry/models/hf/hf_causal_lm.py Show resolved Hide resolved
@mvpatel2000 mvpatel2000 merged commit 9025b83 into main Oct 3, 2023
9 checks passed
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/free-mem branch October 3, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchiley vchiley vchiley approved these changes

@dakinggg dakinggg Awaiting requested review from dakinggg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvpatel2000 @vchiley