Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt composer -> HF conversion script to support all causal lms #526

Merged
merged 4 commits into from
Aug 18, 2023

Conversation

dakinggg
Copy link
Collaborator

@dakinggg dakinggg commented Aug 16, 2023

Adapts the composer -> hf conversion script to support all hf causal lms instead of just MPT. Also removes one of the helper functions that is now fully implemented in composer. The rest can move to composer after a couple more bugs are fixed upstream.

Evidence that the llama2 test passes:
Screenshot 2023-08-15 at 1 36 48 PM

Manual tested training, converting, and loading back in a llama2 model as well.

@dakinggg dakinggg changed the title Conversion script Adapt composer -> HF conversion script to support all causal lms Aug 16, 2023
@dakinggg dakinggg marked this pull request as ready for review August 16, 2023 01:13
Copy link
Collaborator

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest can move to composer after a couple more bugs are fixed upstream.

what are the bugs?

@dakinggg
Copy link
Collaborator Author

I have jira for them, but its with saving the tokenizer for llama2, can't use a temp dir, and need to not assume that all filenames are unique

@dakinggg dakinggg merged commit 9946fc6 into mosaicml:main Aug 18, 2023
9 checks passed
@dakinggg dakinggg deleted the conversion-script branch September 9, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants