Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr eval lora #515

Merged
merged 11 commits into from
Aug 15, 2023
Merged

Pr eval lora #515

merged 11 commits into from
Aug 15, 2023

Conversation

danbider
Copy link
Contributor

@danbider danbider commented Aug 10, 2023

Modified from @SingL3 PR to pin down peft version.

Previously saw conflicts between the huggingface/peft/main and the accelerate library that was pinned down in llm-foundry.

Tested this on an interactive session with:

  • hf lora module as tested by @SingL3.
  • a Composer checkpoint of a trained peft/lora model (trained on pile-of-law).
    eval works fine in both cases.

Copy link
Contributor

@codestar12 codestar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codestar12 codestar12 merged commit 7b1e4ea into mosaicml:main Aug 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants