Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MLFlow as a logger option #475

Merged
merged 11 commits into from
Aug 7, 2023
Merged

Add MLFlow as a logger option #475

merged 11 commits into from
Aug 7, 2023

Conversation

aspfohl
Copy link
Contributor

@aspfohl aspfohl commented Jul 20, 2023

Installs mflow by default and allows for mlflow logging!

You just need to specify the mlflow logger in the yaml, this will even work for hosted mlflow:

  loggers:
    mlflow:
      experiment_name: /Users/<email>/<experimentfolder>

@aspfohl aspfohl changed the title Anna/temp Add MLFlow as a logger option Jul 20, 2023
@aspfohl aspfohl marked this pull request as ready for review July 20, 2023 17:06
@aspfohl aspfohl requested review from eracah and dakinggg July 20, 2023 17:07
Copy link
Contributor

@eracah eracah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Can you add mlflow.log_params(params=om.to_container(cfg, resolve=True)) to the log_config function similar to how WandB does it

@aspfohl aspfohl requested a review from eracah July 20, 2023 18:27
Copy link
Contributor

@eracah eracah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eracah eracah merged commit ad6545c into main Aug 7, 2023
9 checks passed
@dakinggg dakinggg deleted the anna/temp branch October 11, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants