Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing import #470

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Fix missing import #470

merged 1 commit into from
Jul 20, 2023

Conversation

bcui19
Copy link
Contributor

@bcui19 bcui19 commented Jul 20, 2023

No description provided.

@bcui19 bcui19 requested a review from dakinggg July 20, 2023 04:06
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separately can you add a test that would've caught this?

@dakinggg
Copy link
Collaborator

@bcui19 I manually tested that quickstart works again after this change, so I'm going to go ahead and merge, but please add a test that would've caught this. Thanks!

@dakinggg dakinggg merged commit ca0bf0f into main Jul 20, 2023
10 checks passed
@dakinggg dakinggg deleted the bcui19/fix_missing_import branch October 11, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants