Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use mono checkpoints #448

Merged
merged 1 commit into from
Jul 17, 2023
Merged

use mono checkpoints #448

merged 1 commit into from
Jul 17, 2023

Conversation

samhavens
Copy link
Contributor

@samhavens samhavens commented Jul 10, 2023 •
edited
Loading

Users are ending up with sharded checkpoints, unable to convert to HF format. I believe that removing this line will cause us to save mono checkpoints.

@samhavens
Update mpt-30b-instruct.yaml
5717258 
remove sharded state dict
@samhavens samhavens requested a review from dakinggg July 10, 2023 20:51
dakinggg
dakinggg approved these changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just wanted to make sure there wasn't a reason it was originally written this way

@samhavens
Copy link
Contributor Author

Same

@samhavens samhavens merged commit 3b0b678 into main Jul 17, 2023
10 checks passed
@samhavens samhavens deleted the samhavens-patch-2 branch July 17, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

@alextrott16 alextrott16 Awaiting requested review from alextrott16

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samhavens @dakinggg