Revert "Torch2 (#177) (#178)" #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bb7f8bb.
|
i have some problems from you datasets folder and datasets library, i just renamed your folder, it's was circular import error |
|
@vchiley what's about use of mpt from your torch2.0 branch? it will be installed right? |
vchiley
added a commit
to vchiley/llm-foundry
that referenced
this pull request
May 22, 2023
This reverts commit 89f56d2.
vchiley
added a commit
that referenced
this pull request
May 24, 2023
* fix and test * Revert "Revert "Torch2 (#177) (#178)" (#181)" This reverts commit 89f56d2. * updt import try except * updt hf model * updt imports * lint * add mpt hf model init / gen test * updt for temp testing * lint * rerun tests * Update .github/workflows/release.yaml Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com> * Update tests/test_hf_mpt_gen.py Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com> * add cpu test * updt tests / cpu img * updt cpu test install * rerun tests * fix hf import structure * fix test * pull_request -> pull_request_target * make onnx test smaller --------- Co-authored-by: Daniel King <daniel@mosaicml.com> Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
bmosaicml
pushed a commit
that referenced
this pull request
Jun 6, 2023
allow users to set custom groups for finetuning
bmosaicml
pushed a commit
that referenced
this pull request
Jun 8, 2023
* fix and test * Revert "Revert "Torch2 (#177) (#178)" (#181)" This reverts commit 601d61a. * updt import try except * updt hf model * updt imports * lint * add mpt hf model init / gen test * updt for temp testing * lint * rerun tests * Update .github/workflows/release.yaml Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com> * Update tests/test_hf_mpt_gen.py Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com> * add cpu test * updt tests / cpu img * updt cpu test install * rerun tests * fix hf import structure * fix test * pull_request -> pull_request_target * make onnx test smaller --------- Co-authored-by: Daniel King <daniel@mosaicml.com> Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit bb7f8bb.
We are temporarily reverting the change to support torch2, because it needs to be synced with a change to the models on the huggingface hub, otherwise
mosaicml/mpt-7bcannot be used after installing foundry from main. Additionally, a change to (and probably a test for) theconvert_composer_to_hf.pyscript is needed, as the new relative import inside a function is not getting parsed properly.