Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tensorboard logger to yaml config #166

Merged
merged 4 commits into from
May 24, 2023
Merged

Add Tensorboard logger to yaml config #166

merged 4 commits into from
May 24, 2023

Conversation

hanlint
Copy link
Collaborator

@hanlint hanlint commented May 18, 2023

Based on community request (#158 ), this adds support for composer's TensorboardLogger to our config.

@hanlint hanlint mentioned this pull request May 18, 2023
Copy link
Contributor

@vchiley vchiley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

showing a run with tensorboard enabled would be good just to verify it works.

@hanlint
Copy link
Collaborator Author

hanlint commented May 19, 2023

@sysusicily is this something you can help test?

@abhi-mosaic
Copy link
Member

Tested this and confirms it works. Thanks @hanlint !
Screenshot 2023-05-24 at 1 34 19 PM

@abhi-mosaic abhi-mosaic merged commit 3579af6 into main May 24, 2023
6 checks passed
@hanlint hanlint deleted the hanlin/tb branch May 26, 2023 19:49
bmosaicml pushed a commit that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants