Add EnvironmentLogger Callback #1350
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested it with both MLflow and Wandb, where it produced the following MLFlow
Wandb
|
mvpatel2000
reviewed
Jul 22, 2024
There was a problem hiding this comment.
Should this be included in the state data and logged? @eracah
|
Pushed an update fixing the failing checks. Let me know if it's good to go or if there's anything that needs to be changed |
mvpatel2000
requested review from
bigning,
eracah,
j316chuck,
b-chu and
dakinggg
b-chu
reviewed
Jul 31, 2024
There was a problem hiding this comment.
Rename file to env_logging_callback
| from composer.loggers import Logger | ||
|
|
||
|
|
||
| class EnvironmentLoggerCallback(Callback): |
There was a problem hiding this comment.
Rename to EnvironmentLoggingCallback
| The collected information is logged as hyperparameters at the start of model fitting. | ||
| """ | ||
|
|
||
| PACKAGES_TO_LOG = [ |
There was a problem hiding this comment.
Make private module level constant
| @@ -75,6 +75,7 @@ | |||
| 'tenacity>=8.2.3,<9', | |||
| 'catalogue>=2,<3', | |||
| 'typer<1', | |||
| 'GitPython==3.1.43', | |||
Comment on lines
+131
to
+134
| 'world_size': int(os.environ.get('WORLD_SIZE', 1)), | ||
| 'local_world_size': int(os.environ.get('LOCAL_WORLD_SIZE', 1)), | ||
| 'rank': int(os.environ.get('RANK', 0)), | ||
| 'local_rank': int(os.environ.get('LOCAL_RANK', 0)), |
| } | ||
|
|
||
| def _get_docker_info(self) -> dict[str, Any]: | ||
| from mcli import sdk |
There was a problem hiding this comment.
Is this not a new dependency?
| self.env_data['distributed_info'] = self._get_distributed_info() | ||
|
|
||
| # Log the collected data | ||
| logger.log_hyperparameters({'environment_data': self.env_data}) |
There was a problem hiding this comment.
Does this get logged to mosaciml logger?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new callback to simplify logging environment metadata for reproducibility purposes:
Main change is that GitPython now becomes a dependency. It is already a composer[dev] dependency. I was not sure if it was worth gating under a additional dependency