-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Eval to Foundry CLI #1345
Add Eval to Foundry CLI #1345
Conversation
Working tests: test-eval-qQI2O7 runs: test-eval-jG8CT2 runs: |
Is there a better name for the llmfoundry/train folder? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should have llmfoundry.train.eval
. That naming doesn't make sense to me.
|
Test run too show working [Updated]: mcli logs test-eval-cli-U54lW1: mcli logs test-eval-orig-5TibQk: |
This PR allows users to call composer llm-foundry eval {YAML_PATH} {ARGS} while maintaining correctness with existing evaluation script. The motivation is for DLE where we want to make the CLI much more intuitive in the docker images