Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Eval to Foundry CLI #1345

Merged
merged 31 commits into from
Jul 16, 2024
Merged

Add Eval to Foundry CLI #1345

merged 31 commits into from
Jul 16, 2024

Conversation

KuuCi
Copy link
Contributor

@KuuCi KuuCi commented Jul 10, 2024

This PR allows users to call composer llm-foundry eval {YAML_PATH} {ARGS} while maintaining correctness with existing evaluation script. The motivation is for DLE where we want to make the CLI much more intuitive in the docker images

@KuuCi
Copy link
Contributor Author

KuuCi commented Jul 11, 2024

Working tests:
test-eval-rdrmLF runs:
composer -c llmfoundry eval eval/yamls/hf_eval.yaml || (echo "Command failed - killing python" && pkill python && exit 1)

test-eval-qQI2O7 runs:
composer -n 8 -c llmfoundry eval eval/yamls/hf_eval.yaml || (echo "Command failed - killing python" && pkill python && exit 1)

test-eval-jG8CT2 runs:
composer llmfoundry eval/eval.py eval/yamls/hf_eval.yaml || (echo "Command failed - killing python" && pkill python && exit 1)

@KuuCi KuuCi marked this pull request as ready for review July 11, 2024 20:18
@KuuCi KuuCi requested a review from a team as a code owner July 11, 2024 20:18
@KuuCi KuuCi requested review from irenedea and b-chu July 11, 2024 20:18
@b-chu
Copy link
Contributor

b-chu commented Jul 11, 2024

Is there a better name for the llmfoundry/train folder?

Copy link
Contributor

@irenedea irenedea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should have llmfoundry.train.eval. That naming doesn't make sense to me.

@b-chu
Copy link
Contributor

b-chu commented Jul 11, 2024

llmfoundry.train.train also doesn't seem great

@KuuCi KuuCi requested a review from dakinggg July 16, 2024 09:53
@KuuCi
Copy link
Contributor Author

KuuCi commented Jul 16, 2024

Test run too show working [Updated]:

mcli logs test-eval-cli-U54lW1:
composer -n 8 -c llmfoundry eval eval/yamls/hf_eval.yaml || (echo "Command failed - killing python" && pkill python && exit 1)

mcli logs test-eval-orig-5TibQk:
composer eval/eval.py eval/yamls/hf_eval.yaml || (echo "Command failed - killing python" && pkill python && exit 1)

tests/a_scripts/eval/test_eval.py Outdated Show resolved Hide resolved
tests/a_scripts/eval/test_eval_inputs.py Outdated Show resolved Hide resolved
llmfoundry/command_utils/eval.py Outdated Show resolved Hide resolved
@irenedea irenedea self-requested a review July 16, 2024 20:30
@KuuCi KuuCi merged commit 94e0809 into main Jul 16, 2024
9 checks passed
@dakinggg dakinggg deleted the eval-cli branch August 6, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants