Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping mlflow version to include buffering #1303

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

JackZ-db
Copy link
Contributor

The MlFlow version was previously capped at 2.14, leading to llm-foundry regression tests generating abnormal mlflow traffic. Updated to the correct version of MlFlow, at 'mlflow>=2.14.1,<3.0'.

@JackZ-db JackZ-db requested a review from dakinggg June 24, 2024 19:22
@JackZ-db JackZ-db requested a review from a team as a code owner June 24, 2024 19:22
Copy link

@chenmoneygithub chenmoneygithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

Copy link
Collaborator

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just remove given we use mlflow target w composer? @dakinggg @irenedea

setup.py Outdated Show resolved Hide resolved
@JackZ-db JackZ-db merged commit 2267bc7 into mosaicml:main Jun 24, 2024
11 checks passed
dakinggg pushed a commit that referenced this pull request Jun 24, 2024
* bumping mlflow version to include buffering

* capping at mlflow 2.15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants