Remove spurious warning #1258
Merged
Remove spurious warning #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShashankMosaicML
approved these changes
Jun 6, 2024
KuuCi
pushed a commit
that referenced
this pull request
Jun 7, 2024
(cherry picked from commit 3966f0e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warning isn't helpful (and is confusing for the finetuning case). Only
textdataloader accepts eos/bos token id, to be used for per sequence attention masking on pretokenized and concatenated sequences. Essentially all tokenizers have an eos/bos, and if you use mpt withattn_uses_sequence_id(to enable per sequence masking) without an eos/bos specified, you will get an error separately from this one.finetuningdataloader does not accept this.