Bump Version to 0.10.0.dev0 #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milocress
reviewed
Jun 5, 2024
milocress
reviewed
Jun 5, 2024
These changes are necessary as the deprecation broke compatibility with `update_batch_size`.
fix typo
snarayan21
previously approved these changes
Jun 6, 2024
|
I'd also want @dakinggg to sign off |
snarayan21
dismissed
their stale review
don't want this to accidentally get merged rn
mvpatel2000
reviewed
Jun 6, 2024
|
@mvpatel2000 we do deprecations in the version bump pr. but also we're gonna wait for the composer bump pr first |
dakinggg
reviewed
Jun 6, 2024
dakinggg
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working Reg test:
https://databricks.slack.com/archives/C05T1A4UMT8/p1717616549129609
This PR not only bumps the version of LLM-Foundry, but also deprecates top-level variables from yamls. We no longer warn the user but outright throw an error.