Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change TE docker image to enable te_shard_weight #1251

Merged
merged 6 commits into from
Jun 4, 2024
Merged

Change TE docker image to enable te_shard_weight #1251

merged 6 commits into from
Jun 4, 2024

Conversation

j316chuck
Copy link
Contributor

@j316chuck j316chuck commented Jun 4, 2024 •
edited
Loading

Description

Change foundry docker images to use fork of TE that has prepare_te_modules_for_fsdp

Issues Fixed:

chuck-7b-starcoder2x-fp8-run1-ENdcdf fails with:

[rank0]: ImportError: cannot import name 'prepare_te_modules_for_fsdp' from 'transformer_engine.pytorch.distributed' (/usr/lib/python3/dist-packages/transformer_engine/pytorch/distributed.py)

when te_shard_weight: true

To fix, we need to use/pin a branch of TE that has this module in order to the 700 tflops numbers

mvpatel2000
mvpatel2000 reviewed Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz fork branch to a repo you own and pin to a commit hash instead of a branch

@j316chuck j316chuck marked this pull request as ready for review June 4, 2024 05:41
@j316chuck j316chuck requested a review from a team as a code owner June 4, 2024 05:41
@j316chuck j316chuck enabled auto-merge (squash) June 4, 2024 05:42
@j316chuck j316chuck changed the title Change te docker images to use Change TE docker image to enable te_shard_weight Jun 4, 2024
@j316chuck j316chuck disabled auto-merge June 4, 2024 07:16
@j316chuck j316chuck enabled auto-merge (squash) June 4, 2024 20:28
@j316chuck j316chuck merged commit ac56dc5 into main Jun 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@j316chuck @mvpatel2000