Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retries to downloads in convert_text_to_mds.py #1238

Merged
merged 4 commits into from
May 24, 2024
Merged

Add retries to downloads in convert_text_to_mds.py #1238

merged 4 commits into from
May 24, 2024

Conversation

irenedea
Copy link
Contributor

@irenedea irenedea commented May 24, 2024 •
edited
Loading

Add retries to downloads in convert_text_to_mds.py.

Test run: test-mds-conversion-TQ4LB3 confirmed still works

@irenedea irenedea requested a review from dakinggg May 24, 2024 21:15
dakinggg
dakinggg approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just add quick manual test that the download script still works

@irenedea
Copy link
Contributor Author

@dakinggg Done, added to PR description

@irenedea irenedea enabled auto-merge (squash) May 24, 2024 21:39
@irenedea irenedea merged commit fdaa58b into mosaicml:main May 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@irenedea @dakinggg