Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attr error for attention_classes when using act ckpt #1230

Merged
merged 2 commits into from
May 24, 2024

Conversation

cli99
Copy link
Contributor

@cli99 cli99 commented May 23, 2024

attention_classes was recently changed to type TypedRegistry, thus get_all() shall be used instead of keys() . keys() causes attribute not found error.

@cli99 cli99 requested a review from dakinggg May 23, 2024 00:55
@cli99 cli99 changed the title Fix bug of attr error for attention_classes Fix attr error for attention_classes when using act ckpt May 23, 2024
@dakinggg dakinggg merged commit b4bb34c into mosaicml:main May 24, 2024
9 checks passed
@cli99 cli99 deleted the fix-act-ckpt branch May 28, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants