Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user error superclass #1225

Merged
merged 3 commits into from
May 22, 2024
Merged

Add user error superclass #1225

merged 3 commits into from
May 22, 2024

Conversation

milocress
Copy link
Contributor

Adds a UserError superclass to distinguish network/internal errors from user-actionable errors.

@milocress milocress requested a review from jjanezhang May 22, 2024 17:50
jjanezhang
jjanezhang approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@jjanezhang jjanezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛷️

@jjanezhang
Copy link
Contributor

ooc: why this and not adding is_user_error as a field to the contextual error and default true?

@jjanezhang
Copy link
Contributor

ooc: why this and not adding is_user_error as a field to the contextual error and default true?

addressed offline, added error attribution to contextual error class

@milocress milocress enabled auto-merge (squash) May 22, 2024 18:31
@milocress milocress merged commit 8e29698 into mosaicml:main May 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjanezhang jjanezhang jjanezhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@milocress @jjanezhang