Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example eval scripts for dbrx PT sizes #1218

Merged
merged 8 commits into from
May 24, 2024
Merged

Add example eval scripts for dbrx PT sizes #1218

merged 8 commits into from
May 24, 2024

Conversation

aspfohl
Copy link
Contributor

@aspfohl aspfohl commented May 16, 2024

Here's an example of how these work: eval-dbrx-U4Ew2U
Docs to come in https://docs.mosaicml.com/projects/mcli/en/latest/ (will link PR)

@aspfohl aspfohl requested review from mvpatel2000 and b-chu May 17, 2024 00:46
@aspfohl aspfohl marked this pull request as ready for review May 17, 2024 00:46
Copy link
Collaborator

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you actually run these? can you include mcli run name showing it?

Copy link
Contributor

@b-chu b-chu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To reduce duplication, can we just have 1 yaml and put the model section of the different yamls into a README?

@b-chu
Copy link
Contributor

b-chu commented May 21, 2024

Also is there a good way to keep these yamls up to date with any changes we might make in PAPI in the future?

@aspfohl
Copy link
Contributor Author

aspfohl commented May 21, 2024

@b-chu

To reduce duplication, can we just have 1 yaml and put the model section of the different yamls into a README?

The goal was to make submitting eval yamls as easy as possible, ideally without modifying the checkpoint. See the mcli yaml in the docs here https://github.com/databricks-mosaic/mosaicml-cli/pull/1762

@aspfohl aspfohl enabled auto-merge (squash) May 24, 2024 17:03
@aspfohl aspfohl merged commit ef530bf into main May 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants