Add fc to HF export #1209
Merged
Add fc to HF export #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irenedea
approved these changes
May 15, 2024
snarayan21
approved these changes
May 15, 2024
milocress
approved these changes
May 15, 2024
milocress
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HF export was missing the fc.py file and the associated register, so would result in an error when trying to load the HF exported model. This PR both fixes the issue, and adds a unit test that would've caught it, which requires clearing the registry for the unit test to simulate a fresh environment.
The move of
MultiTokenEOSCriteriais just because Composer dev has removed that class, and it is now in foundry.