Make fc_type a dict to pass fc kwargs through
#1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h/fc_config merging main
…y into saaketh/fc_config merged origin
dakinggg
reviewed
May 14, 2024
…h/fc_config merging main
Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
…h/fc_config merging main
|
finally fixed the ci errors lfg |
dakinggg
reviewed
May 16, 2024
dakinggg
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some custom FC layers will need custom kwargs. This PR enables that by changing
fc_typefromstrtoUnion[str, Dict], and converting it to dict thereafter.Default configs have also been moved to their own file, keeping those defaults easily accessible.
We will likely seek to deprecate fc_type down the line and replace it with fc_config instead.