Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix eval #1193

Merged
merged 2 commits into from
May 10, 2024
Merged

fix eval #1193

merged 2 commits into from
May 10, 2024

Conversation

milocress
Copy link
Contributor

@milocress milocress commented May 9, 2024 •
edited
Loading

Manual tests

Eval

eval-7b-hf-dIE2JY

Train

ift-mpt-7b-lrhex4-Ykz4Tq

if both of these runs run without error, you're good to merge IMO

dakinggg
dakinggg approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please wait for the manual tests to pass before merging.

@milocress milocress merged commit 983234d into mosaicml:main May 10, 2024
9 checks passed
@milocress milocress deleted the milo/fix-eval branch May 10, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

@irenedea irenedea Awaiting requested review from irenedea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@milocress @dakinggg