Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log eval dataset misconfiguration #1179

Merged

Conversation

milocress
Copy link
Contributor

@milocress milocress commented May 7, 2024

Make Eval Dataset Misconfiguration Errors Visible through Mosaic Logger

Wraps eval dataset creation with a mosaic logger try/catch.

In Train context

mpt-125m-chinchilla-regression-6OSoWo (the log trace indicates that the error is caught and the context attribute is set)

[rank7]: │   623 │   │   if mosaicml_logger is not None:                                │
[rank7]: │   624 │   │   │   e.context = 'TrainContext'                                 │
[rank7]: │   625 │   │   │   mosaicml_logger.log_exception(e)                           │
[rank7]: │ ❱ 626 │   │   raise e 

In Eval context

mpt-125m-chinchilla-regression-6OSoWo (the log trace indicates that the error is caught and the context attribute is set)

[rank0]: │   656 │   │   │   if mosaicml_logger is not None:                            │
[rank0]: │   657 │   │   │   │   e.context = 'EvalContext'                              │
[rank0]: │   658 │   │   │   │   mosaicml_logger.log_exception(e)                       │
[rank0]: │ ❱ 659 │   │   │   raise e  

@milocress milocress requested a review from dakinggg May 7, 2024 00:59
Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a run name for a manual test?

@milocress milocress requested a review from dakinggg May 7, 2024 21:34
Copy link
Contributor

@jjanezhang jjanezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, had a comment on renaming so we can use this for many things in the future.

Flagging that the dataset type won't be added in the convert_delta_to_json.py and convert_text_to_mds.py. I think we would have to parse the datapath to get the train split to wrap the error if you'd like to take a stab! Also happy to do it :) thanks so much Milo!

llmfoundry/utils/exceptions.py Outdated Show resolved Hide resolved
@milocress
Copy link
Contributor Author

Flagging that the dataset type won't be added in the convert_delta_to_json.py and convert_text_to_mds.py. I think we would have to parse the datapath to get the train split to wrap the error if you'd like to take a stab! Also happy to do it :) thanks so much Milo!

I am happy to do this, but let's split it into a separate PR so this one stays small.

@milocress milocress requested a review from jjanezhang May 13, 2024 17:11
Copy link
Contributor

@jjanezhang jjanezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, otherwise lgtm

scripts/train/train.py Outdated Show resolved Hide resolved
@milocress milocress enabled auto-merge (squash) May 15, 2024 22:01
@milocress milocress merged commit cfee4e4 into mosaicml:main May 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants