-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log eval dataset misconfiguration #1179
log eval dataset misconfiguration #1179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a run name for a manual test?
…ilocress/llm-foundry into milo/log-eval-dataset-misconfiguration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, had a comment on renaming so we can use this for many things in the future.
Flagging that the dataset type won't be added in the convert_delta_to_json.py
and convert_text_to_mds.py
. I think we would have to parse the datapath to get the train split to wrap the error if you'd like to take a stab! Also happy to do it :) thanks so much Milo!
I am happy to do this, but let's split it into a separate PR so this one stays small. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit, otherwise lgtm
Make Eval Dataset Misconfiguration Errors Visible through Mosaic Logger
Wraps eval dataset creation with a mosaic logger try/catch.
In Train context
mpt-125m-chinchilla-regression-6OSoWo
(the log trace indicates that the error is caught and the context attribute is set)In Eval context
mpt-125m-chinchilla-regression-6OSoWo
(the log trace indicates that the error is caught and the context attribute is set)