Add line splitting and other linting #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvpatel2000
reviewed
May 1, 2024
There was a problem hiding this comment.
@b-chu should we raise min line length to be 100? it seems smaller than composer? or maybe im dumb.
I think looks good to me, would like daniel's pass too
b-chu
force-pushed
the
brian/lint
branch
2 times, most recently
from
b1463a1
to
f988c08
Compare
|
Yes foundry is 80 but composer is 120. There are many other style inconsistencies between the two repos :) I'm going to say that's out of the scope of this PR and we should discuss how/if we want to reconcile. |
b-chu
force-pushed
the
brian/lint
branch
5 times, most recently
from
cc15f23
to
1d4b71c
Compare
mvpatel2000
approved these changes
May 2, 2024
dakinggg
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds line splitting and trailing commas similar to mosaicml/composer#3078