Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build inner model #1147

Merged
merged 17 commits into from
Apr 29, 2024
Merged

build inner model #1147

merged 17 commits into from
Apr 29, 2024

Conversation

milocress
Copy link
Contributor

@milocress milocress commented Apr 29, 2024 •
edited
Loading

Helper method to return inner model without needing to call __init__(...).model and go through unnecessary side-effects.

dakinggg
dakinggg approved these changes Apr 29, 2024
View reviewed changes
llmfoundry/models/hf/hf_causal_lm.py Outdated Show resolved Hide resolved
llmfoundry/models/hf/hf_causal_lm.py Outdated Show resolved Hide resolved
@milocress milocress merged commit de5a394 into mosaicml:main Apr 29, 2024
9 checks passed
@milocress milocress deleted the milo/build-inner-model branch April 29, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

@irenedea irenedea Awaiting requested review from irenedea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milocress @dakinggg