Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strict key checking for dataset #1131

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Strict key checking for dataset #1131

merged 1 commit into from
Apr 24, 2024

Conversation

b-chu
Copy link
Contributor

@b-chu b-chu commented Apr 23, 2024 •
edited
Loading

  • Moves global constants to exceptions
  • Changes error parameter to string
  • Dataset keys must match strict key names
    • only ALLOWED_MESSAGES_KEYS OR
    • one of
      • ALLOWED_RESPONSE_KEYS AND
      • ALLOWED_PROMPT_KEYS

@b-chu b-chu force-pushed the jane_debug branch 3 times, most recently from 328c070 to f42cebd Compare April 23, 2024 01:58
@b-chu b-chu force-pushed the jane_debug branch 6 times, most recently from 9aff3b5 to 05f7612 Compare April 24, 2024 16:49
@b-chu b-chu requested a review from irenedea April 24, 2024 16:54
@b-chu b-chu merged commit 6252f79 into main Apr 24, 2024
9 checks passed
@b-chu b-chu deleted the jane_debug branch May 1, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irenedea irenedea irenedea approved these changes

@dakinggg dakinggg Awaiting requested review from dakinggg

@jjanezhang jjanezhang Awaiting requested review from jjanezhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@b-chu @irenedea