Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch misconfigured hf dataset #1123

Merged

Conversation

milocress
Copy link
Contributor

@milocress milocress commented Apr 19, 2024

Catches misconfigured hf dataset and wraps error in an llmfoundry exception that can be surfaced to users.

@milocress milocress requested a review from dakinggg April 19, 2024 17:35
Copy link
Contributor

@jjanezhang jjanezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you sm :)

llmfoundry/utils/exceptions.py Outdated Show resolved Hide resolved
dakinggg and others added 2 commits April 19, 2024 11:41
Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
@milocress milocress enabled auto-merge (squash) April 19, 2024 18:50
@milocress milocress merged commit f0646e8 into mosaicml:main Apr 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants