FFN layer registry #1095
Merged
FFN layer registry #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
commented
Apr 4, 2024
dakinggg
commented
Apr 4, 2024
mvpatel2000
reviewed
Apr 12, 2024
|
And with the MB merge: 
@irenedea @mvpatel2000 this one is ready |
|
jk, also failed a test |
|
ok @mvpatel2000 tests passing now |
mvpatel2000
reviewed
Apr 12, 2024
There was a problem hiding this comment.
why do the megablocks ones have to be separate?
@vchiley to review the mb build stuff
|
@mvpatel2000 because there are a bunch of places in the code that we do something only for the mb layers (e.g. the mb args as an attr on the main class. |
mvpatel2000
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before and after
