Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump HF version #1091

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Bump HF version #1091

merged 1 commit into from
Apr 4, 2024

Conversation

b-chu
Copy link
Contributor

@b-chu b-chu commented Apr 4, 2024

This file which gets imported through llmfoundry/data/__init__.py isn't available until 0.19.0 on huggingface_hub.
https://github.com/huggingface/huggingface_hub/blob/v0.19.0/src/huggingface_hub/utils/insecure_hashlib.py

Stack trace:

(mosaicml_venv) root@c3b3495a-cd8c-4e0f-a4da-f6bb0dea0f08-0:/mnt/workdisk/brian/llm-foundry# python llmfoundry/data/__init__.py
Traceback (most recent call last):
  File "/mnt/workdisk/brian/llm-foundry/llmfoundry/data/__init__.py", line 4, in <module>
    from llmfoundry.data.data import ConcatTokensDataset, NoConcatDataset
  File "/mnt/workdisk/brian/llm-foundry/llmfoundry/__init__.py", line 12, in <module>
    from llmfoundry.utils.logging_utils import SpecificWarningFilter
  File "/mnt/workdisk/brian/llm-foundry/llmfoundry/utils/__init__.py", line 4, in <module>
    from llmfoundry.utils.builders import (build_algorithm, build_callback,
  File "/mnt/workdisk/brian/llm-foundry/llmfoundry/utils/builders.py", line 29, in <module>
    from llmfoundry.data.dataloader import build_dataloader
  File "/mnt/workdisk/brian/llm-foundry/llmfoundry/data/__init__.py", line 4, in <module>
    from llmfoundry.data.data import ConcatTokensDataset, NoConcatDataset
  File "/mnt/workdisk/brian/llm-foundry/llmfoundry/data/data.py", line 9, in <module>
    import datasets as hf_datasets
  File "/mnt/workdisk/brian/mosaicml_venv/lib/python3.10/site-packages/datasets/__init__.py", line 22, in <module>
    from .arrow_dataset import Dataset
  File "/mnt/workdisk/brian/mosaicml_venv/lib/python3.10/site-packages/datasets/arrow_dataset.py", line 66, in <module>
    from .arrow_reader import ArrowReader
  File "/mnt/workdisk/brian/mosaicml_venv/lib/python3.10/site-packages/datasets/arrow_reader.py", line 30, in <module>
    from .download.download_config import DownloadConfig
  File "/mnt/workdisk/brian/mosaicml_venv/lib/python3.10/site-packages/datasets/download/__init__.py", line 9, in <module>
    from .download_manager import DownloadManager, DownloadMode
  File "/mnt/workdisk/brian/mosaicml_venv/lib/python3.10/site-packages/datasets/download/download_manager.py", line 31, in <module>
    from ..utils import tqdm as hf_tqdm
  File "/mnt/workdisk/brian/mosaicml_venv/lib/python3.10/site-packages/datasets/utils/__init__.py", line 19, in <module>
    from .info_utils import VerificationMode
  File "/mnt/workdisk/brian/mosaicml_venv/lib/python3.10/site-packages/datasets/utils/info_utils.py", line 5, in <module>
    from huggingface_hub.utils import insecure_hashlib
ImportError: cannot import name 'insecure_hashlib' from 'huggingface_hub.utils' (/mnt/workdisk/brian/mosaicml_venv/lib/python3.10/site-packages/huggingface_hub/utils/__init__.py)

@b-chu b-chu requested a review from a team as a code owner April 4, 2024 16:22
@b-chu b-chu requested review from irenedea and dakinggg April 4, 2024 16:22
@dakinggg dakinggg merged commit 26f0619 into main Apr 4, 2024
9 checks passed
KuuCi pushed a commit that referenced this pull request Apr 18, 2024
@b-chu b-chu deleted the hf-bump branch May 1, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants