Background mlflow model registration #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irenedea
commented
Mar 31, 2024
dakinggg
reviewed
Apr 1, 2024
dakinggg
reviewed
Apr 1, 2024
dakinggg
reviewed
Apr 1, 2024
dakinggg
reviewed
Apr 1, 2024
Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
dakinggg
pushed a commit
to dakinggg/llm-foundry
that referenced
this pull request
Apr 4, 2024
KuuCi
pushed a commit
that referenced
this pull request
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spawn a new process that handles the mlflow model registration (which uploads the model to UC). This way, global rank 0 isn't stuck on with a long operation with variable speeds, which could lead to nccl timeouts. This also allows other operations to happen concurrently such as composer checkpoint saving, etc.
At the end of training, we wait for all child processes to finish and clean up temporary directories.
Manual Test
test-hf-mlflow-background-register-ib6LgHtest-hf-mlflow-background-register-llama70b-Lhda8z