Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expandeable segments flag #1075

Merged
merged 4 commits into from
Apr 1, 2024
Merged

Add expandeable segments flag #1075

merged 4 commits into from
Apr 1, 2024

Conversation

dakinggg
Copy link
Collaborator

No description provided.

@dakinggg dakinggg changed the title Expandeable Add expandeable segments flag Mar 29, 2024
@dakinggg dakinggg marked this pull request as ready for review March 29, 2024 16:53
Copy link
Collaborator

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should env vars be in yamls its a bit weird imo 🤷

@dakinggg
Copy link
Collaborator Author

@mvpatel2000 I think for important ones its much easier to set them with a defined flag, than rely on everyone knowing the precise syntax to set the env var. Also its much harder to provide full examples if they can't be set in the yaml.

scripts/train/train.py Outdated Show resolved Hide resolved
scripts/train/train.py Show resolved Hide resolved
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
@dakinggg dakinggg enabled auto-merge (squash) April 1, 2024 17:39
@dakinggg dakinggg merged commit 349c2ff into mosaicml:main Apr 1, 2024
9 checks passed
KuuCi pushed a commit that referenced this pull request Apr 18, 2024
@dakinggg dakinggg deleted the expandeable branch June 22, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants