Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Composer to 0.21.1 #1053

Merged
merged 7 commits into from
Mar 24, 2024
Merged

Bump Composer to 0.21.1 #1053

merged 7 commits into from
Mar 24, 2024

Conversation

jjanezhang
Copy link
Contributor

No description provided.

Copy link
Collaborator

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjanezhang please run the regression tests against this PR, lmk if you don't know how to do that

@dakinggg
Copy link
Collaborator

dakinggg commented Mar 23, 2024

@jjanezhang you'll need to update fsdp_elastic_sharded_enabled to fsdp_sharded_state_dict_enabled in the AsyncEvalCallback in order for code quality to pass (and for the callback to work)

@dakinggg
Copy link
Collaborator

dakinggg commented Mar 24, 2024

regression run here: llm-foundry-regression-tests-runner-lGHRyy

@dakinggg dakinggg marked this pull request as ready for review March 24, 2024 17:54
@dakinggg dakinggg requested a review from a team as a code owner March 24, 2024 17:54
@dakinggg dakinggg merged commit 5c8a829 into main Mar 24, 2024
10 checks passed
jjanezhang added a commit that referenced this pull request Mar 25, 2024
* bump composer

* accounted for bug fix

* changed fsdp_elastic_sharded_enabled to fsdp_sharded_state_dict_enabled in the AsyncEvalCallback

---------

Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
KuuCi pushed a commit that referenced this pull request Apr 18, 2024
* bump composer

* accounted for bug fix

* changed fsdp_elastic_sharded_enabled to fsdp_sharded_state_dict_enabled in the AsyncEvalCallback

---------

Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants